On Mon, Jan 14 2013, Minchan Kim <minchan@xxxxxxxxxx> wrote: > I'm not familar with Python but I can see the point of the program. > It's very short and good for maintainace but I have a concern about the size. > For working it in embedded side, we have to port python in that > machine. :( [...] > In case of that, just small C program when we release product would be > good choice. But is this program intended to be used as is? Or rather to serve as an example? If the former, than I think it should be in tools/ rather than in Documentation/. If the latter, than I think it does not really matter whether it's C or some scripting language, since the purpose is to show how /proc/page_owner can be used, and in fact showing the general idea may be simpler with a shorter program which does not have to deal with memory management. And if Python is not your fancy, you can always use some shell: ;) awk -vRS= '{ gsub("\n", "\\n"); print $0 }' |sort |uniq -c > But I'm not strong aginst on your simple python program. If it is merged, > we will just continue to use C program instead of python's one. > If you have a strong opinion, send it to akpm as separate patch. Not at all. I'm just throwing ideas. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
Attachment:
pgpJzLmGiEhQ2.pgp
Description: PGP signature