On Fri 11-01-13 20:06:25, Tang Chen wrote:
> On 01/11/2013 06:47 PM, Michal Hocko wrote:
> >>
> >>Darn! And now that I am looking at the patch closer it is too x86
> >>centric so this cannot be in the generic code. I will try to cook
> >>something better. Sorry about the noise.
> >
> >It is more complicated than I thought. One would tell it's a mess.
> >The patch bellow fixes the compilation issue but I am not sure we want
> >to include memory_hotplug.h into arch/x86/mm/init_64.c. Moreover
> >
> >+void register_page_bootmem_memmap(unsigned long section_nr,
> >+ struct page *start_page, unsigned long size)
> >+{
> >+ /* TODO */
> >+}
> >
> >for other archs would suggest that the code is not ready yet. Should
> >this rather be dropped for now?
>
> Hi Michal,
>
> Do you mean remove register_page_bootmem_memmap() from other
> architectures ?
No I meant the patch to be dropped until it gets implementation for
other architectures or the users of the function would be explicit about
archs which are supported. What happens if the implementation is empty
will the generic code work properly? From my very limitted understanding
of the code it won't.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>