On Thu, 10 Jan 2013 11:23:06 +0900 Minchan Kim <minchan@xxxxxxxxxx> wrote: > > I have a feeling that laptop mode has bitrotted and these patches are > > kinda hacking around as-yet-not-understood failures... > > Absolutely, this patch is last guard for unexpectable behavior. > As I mentioned in cover-letter, Luigi's problem could be solved either [1/2] > or [2/2] but I wanted to add this as last resort in case of unexpected > emergency. But you're right. It's not good to hide the problem like this path > so let's drop [2/2]. > > Also, I absolutely agree it has bitrotted so for correcting it, we need a > volunteer who have to inverstigate power saveing experiment with long time. > So [1/2] would be band-aid until that. I'm inclined to hold off on 1/2 as well, really. The point of laptop_mode isn't to save power btw - it is to minimise the frequency with which the disk drive is spun up. By deferring and then batching writeout operations, basically. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>