getc returns "int" so EOF could be -1 but storing getc's return
value to char directly makes the vaule to 255 so below condition
is always false.
It happens in my ARM system so loop is not ended, then segfaulted.
This patch fixes it.
*curr = getc(fin); // *curr = 255
if (*curr == EOF) return -1; // if ( 255 == -1)
Cc: Mel Gorman <mgorman@xxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxx>
Cc: Alexander Nyberg <alexn@xxxxxxxxx>
Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>
---
Documentation/page_owner.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/page_owner.c b/Documentation/page_owner.c
index f0156e1..b777fb6 100644
--- a/Documentation/page_owner.c
+++ b/Documentation/page_owner.c
@@ -32,12 +32,14 @@ int read_block(char *buf, FILE *fin)
{
int ret = 0;
int hit = 0;
+ int vaule;
char *curr = buf;
for (;;) {
- *curr = getc(fin);
- if (*curr == EOF) return -1;
+ value = getc(fin);
+ if (value == EOF) return -1;
+ *curr = value;
ret++;
if (*curr == '\n' && hit == 1)
return ret - 1;
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>