There is only one possible return value of sys_brk, which is mm->brk no matter succeed or not. Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Signed-off-by: Yuanhan Liu <yuanhan.liu@xxxxxxxxxxxxxxx> --- mm/mmap.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index f54b235..ae4093c 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -251,7 +251,7 @@ static unsigned long do_brk(unsigned long addr, unsigned long len); SYSCALL_DEFINE1(brk, unsigned long, brk) { - unsigned long rlim, retval; + unsigned long rlim; unsigned long newbrk, oldbrk; struct mm_struct *mm = current->mm; unsigned long min_brk; @@ -307,9 +307,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk) set_brk: mm->brk = brk; out: - retval = mm->brk; up_write(&mm->mmap_sem); - return retval; + return mm->brk; } static long vma_compute_subtree_gap(struct vm_area_struct *vma) -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>