On Wed, Jan 2, 2013 at 7:57 AM, Christoph Lameter <cl@xxxxxxxxx> wrote:
> On Wed, 2 Jan 2013, Hugh Dickins wrote:
>
>> @@ -2796,10 +2787,7 @@ int mpol_to_str(char *buffer, int maxlen
>> case MPOL_BIND:
>> /* Fall through */
>> case MPOL_INTERLEAVE:
>> - if (no_context)
>> - nodes = pol->w.user_nodemask;
>> - else
>> - nodes = pol->v.nodes;
>> + nodes = pol->v.nodes;
>> break;
>>
>
> no_context was always true. Why is the code from the false branch kept?
no_context is zero in the caller in fs/proc/task_mmu.c, and one in the
mm/shmem.c caller. So it's not always true (for mpol_parse_str() there
is only one caller, and it's always true as Hugh said).
Anyway, I do not know why Hugh took the true case, but I don't really
imagine that it matters. So I'll take these two patches, but it would
be good if you double-checked this, Hugh.
Hugh?
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>