Re: [memcg:since-3.6 493/499] include/trace/events/filemap.h:14:1: sparse: incompatible types for operation (<)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Steven Rostedt <rostedt@xxxxxxxxxxx> writes:

> Sorry for the late reply, It's end of year and I'm getting a lot of
> pressure at work to get things done.
Don't worry, no hurry in here.

> Hmm, this is mostly automated via the macros. Not sure how we can
> differentiate a pointer from other fields. Would this be fixed if we
> did:
>
> #define is_signed_type(type) (((type)(-1) < (type)0)

Yes indeed, this quiesces the sparse warning, and keeps the original purpose
AFAIK. And I don't think C standard provides a way to typecheck for any kind of
pointer, so this looks the right fix to me .

Will you submit the patch or do you want me to send it ?

Cheers.

-- 
Robert

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]