On 12/01/2012 01:55 AM, Pavel Emelyanov wrote: > case MADV_DOTRACE: > + /* > + * Protect pages to be read-only and force tasks to generate > + * #PFs on modification. > + * > + * It should be done before issuing trace-on event. Otherwise > + * we're leaving a short window after the 'on' event when tasks > + * can still modify pages. > + */ > + change_protection(vma, start, end, > + vm_get_page_prot(vma->vm_flags & ~VM_READ), > + vma_wants_writenotify(vma)); Should be VM_WRITE? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>