On Thu, 29 Nov 2012 15:29:15 -0800 (PST) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > On Thu, 29 Nov 2012, Andrew Morton wrote: > > On Wed, 28 Nov 2012 17:22:03 -0800 (PST) > > Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > > > > +/* > > > + * llseek SEEK_DATA or SEEK_HOLE through the radix_tree. > > > + */ > > > +static pgoff_t shmem_seek_hole_data(struct address_space *mapping, > > > + pgoff_t index, pgoff_t end, int origin) > > > > So I was starting at this wondering what on earth "origin" is and why > > it has the fishy-in-this-context type "int". > > > > There is a pretty well established convention that the lseek seek mode > > is called "whence". > > > > The below gets most of it. Too anal? > > No, not too anal: I'm all in favour of "whence", which is indeed > the name of that lseek argument - since mediaeval times I believe. Alas, the rest of us don't have personal memories from those days. > It's good to have words like that in the kernel source: while you're > in the mood, please see if you can find good homes for "whither" and > "thrice" and "widdershins". We use "thrice" quite a lot. And "whither" once coz alfa peeps cnat spel. No widdershins yet. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>