On Thu 29-11-12 22:23:56, Wu Fengguang wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
> head: 8695b9105cdb22a5a4b66eea52c0232cbd5e6e48
> commit: b86ed88f692e53331ef7d6b6b753993df75fc59a [480/499] Reverted "mm, highmem: makes flush_all_zero_pkmaps() return index of last flushed entry"
> config: i386-randconfig-b780 (attached as .config)
>
> All error/warnings:
>
> mm/highmem.c: In function 'kmap_flush_unused':
> mm/highmem.c:157:8: error: void value not ignored as it ought to be
> mm/highmem.c:158:15: error: 'PKMAP_INVALID_INDEX' undeclared (first use in this function)
> mm/highmem.c:158:15: note: each undeclared identifier is reported only once for each function it appears in
Dohh, I have screwed revert of "mm, highmem: makes
flush_all_zero_pkmaps() return index of last flushed entry"
Thanks a lot for the report
The patch bellow should heal this.
---
>From 422a0f651b5cefa1b6b3ede2e1c9e540a24a6e01 Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@xxxxxxx>
Date: Thu, 29 Nov 2012 15:43:47 +0100
Subject: [PATCH] mm: fix compilation issue in kmap_flush_unused
Fengguang has reported the following compilation issue:
mm/highmem.c: In function 'kmap_flush_unused':
mm/highmem.c:157:8: error: void value not ignored as it ought to be
mm/highmem.c:158:15: error: 'PKMAP_INVALID_INDEX' undeclared (first use in this function)
mm/highmem.c:158:15: note: each undeclared identifier is reported only once for each function it appears in
The problem has been introduced by me (and it is specific to this tree)
when reverting 1918c826 (mm, highmem: makes flush_all_zero_pkmaps()
return index of last flushed entry).
Signed-off-by: Michal Hocko <mhocko@xxxxxxx>
---
mm/highmem.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/highmem.c b/mm/highmem.c
index 1bea40d..d999077 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -151,12 +151,8 @@ static void flush_all_zero_pkmaps(void)
*/
void kmap_flush_unused(void)
{
- unsigned int index;
-
lock_kmap();
- index = flush_all_zero_pkmaps();
- if (index != PKMAP_INVALID_INDEX && (index < last_pkmap_nr))
- last_pkmap_nr = index;
+ flush_all_zero_pkmaps();
unlock_kmap();
}
--
1.7.10.4
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>