On Wed, Nov 28, 2012 at 5:24 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > > Please don't duplicate code this way. > > You can move that whole thing to rpm_callback(). Yes, you'll probably need to > check dev->power.memalloc_noio twice in there, but that's OK. Good idea, I will update it in v7. Thanks, -- Ming Lei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>