On Thu, 2012-11-22 at 17:53 +0400, Glauber Costa wrote:
> On 11/22/2012 02:36 PM, Glauber Costa wrote:
> >> @@ -5933,6 +6071,7 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg)
> >> > * the cgroup_lock.
> >> > */
> >> > disarm_static_keys(memcg);
> >> > +
> >> > if (size < PAGE_SIZE)
> >> > kfree(memcg);
> >> > else
>
> Joe,
>
> since you removed the code from my former e-mail:
Because you quoted a whole bunch of lines that
included newlines
> That one after "disarm_static_keys".
Vertical spacing has many uses within a functional
block. I don't see anything wrong with that one.
The one I suspected you meant was:
> +static inline void memcg_dangling_add(struct mem_cgroup *memcg)
> +{
> +
> + memcg->memcg_name = kstrdup(cgroup_name(memcg->css.cgroup), GFP_KERNEL);
I think a blank line after an initial { is suspect.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>