Nothing outside of mm/memory.c references copy_pte_range. linux/huge_mm.h prototypes it, but nothing uses that prototype. Commit 71e3aac0724ffe8918992d76acfe3aad7d8724a5 in January 2011 explicitly made copy_pte_range non-static, but no commit ever introduced a caller for copy_pte_range outside of mm/memory.c. Make the function static. This eliminates a warning from gcc (-Wmissing-prototypes) and from Sparse (-Wdecl). mm/memory.c:917:5: warning: no previous prototype for ‘copy_pte_range’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> --- include/linux/huge_mm.h | 4 ---- mm/memory.c | 7 ++++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 8ed2187..e10d4fe 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -87,10 +87,6 @@ extern int handle_pte_fault(struct mm_struct *mm, #endif /* CONFIG_DEBUG_VM */ extern unsigned long transparent_hugepage_flags; -extern int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm, - pmd_t *dst_pmd, pmd_t *src_pmd, - struct vm_area_struct *vma, - unsigned long addr, unsigned long end); extern int split_huge_page(struct page *page); extern void __split_huge_page_pmd(struct mm_struct *mm, pmd_t *pmd); #define split_huge_page_pmd(__mm, __pmd) \ diff --git a/mm/memory.c b/mm/memory.c index fb135ba..fa106b3 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -914,9 +914,10 @@ out_set_pte: return 0; } -int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm, - pmd_t *dst_pmd, pmd_t *src_pmd, struct vm_area_struct *vma, - unsigned long addr, unsigned long end) +static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm, + pmd_t *dst_pmd, pmd_t *src_pmd, + struct vm_area_struct *vma, + unsigned long addr, unsigned long end) { pte_t *orig_src_pte, *orig_dst_pte; pte_t *src_pte, *dst_pte; -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href