On Fri, Nov 16, 2012 at 09:09:03AM -0500, Rik van Riel wrote: > On 11/16/2012 06:22 AM, Mel Gorman wrote: > >It was pointed out by Ingo Molnar that the per-architecture definition of > >the NUMA PTE helper functions means that each supporting architecture > >will have to cut and paste it which is unfortunate. He suggested instead > >that the helpers should be weak functions that can be overridden by the > >architecture. > > > >This patch moves the helpers to mm/pgtable-generic.c and makes them weak > >functions. Architectures wishing to use this will still be required to > >define _PAGE_NUMA and potentially update their p[te|md]_present and > >pmd_bad helpers if they choose to make PAGE_NUMA similar to PROT_NONE. > > > >Signed-off-by: Mel Gorman <mgorman@xxxxxxx> > > Is uninlining these simple tests really the right thing to do, > or would they be better off as inlines in asm-generic/pgtable.h ? > I would have preferred asm-generic/pgtable.h myself and use __HAVE_ARCH_whatever tricks to keep the inlining but Ingo's suggestion was to use __weak (https://lkml.org/lkml/2012/11/13/134) and I did not have a strong reason to disagree. Is there a compelling choice either way or a preference? -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>