At 11/16/2012 08:29 AM, Andrew Morton Wrote: > On Thu, 15 Nov 2012 16:57:36 +0800 > Wen Congyang <wency@xxxxxxxxxxxxxx> wrote: > >> N_HIGH_MEMORY stands for the nodes that has normal or high memory. >> N_MEMORY stands for the nodes that has any memory. >> >> The code here need to handle with the nodes which have memory, we should >> use N_MEMORY instead. >> >> Since we introduced N_MEMORY, we update the initialization of node_states. > > reset_zone_present_pages() has been removed by the recently-queued > revert-mm-fix-up-zone-present-pages.patch, so I dropped that hunk. > > We still have > > akpm:/usr/src/25> grep N_HIGH_MEMORY mm/page_alloc.c > [N_HIGH_MEMORY] = { { [0] = 1UL } }, > node_set_state(nid, N_HIGH_MEMORY); > if (N_NORMAL_MEMORY != N_HIGH_MEMORY && > > which I hope is correct. Can you please check it? > Yes, it is correct. We will introduce N_MEMORY nodemask in part4, and N_MEMORY is N_HIGH_MEMORY in this patchset. So we don't init and update N_MEMORY nodemask in this patchset. Thanks Wen Congyang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>