(2012/11/15 11:54), Glauber Costa wrote: > Following the pattern found in the allocators, where we do our best to > the fast paths function-call free, all the externally visible functions > for kmemcg were marked __always_inline. > > It is fair to say, however, that this should be up to the compiler. We > will still keep as much of the flag testing as we can in memcontrol.h to > give the compiler the option to inline it, but won't force it. > > I tested this with 4.7.2, it will inline all three functions anyway when > compiling with -O2, and will refrain from it when compiling with -Os. > This seems like a good behavior. > > Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx> > CC: Michal Hocko <mhocko@xxxxxxx> > CC: Kamezawa Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > CC: Johannes Weiner <hannes@xxxxxxxxxxx> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> I'm O.K. with this. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>