On Fri, Oct 26, 2012 at 01:37:31PM +0200, Michal Hocko wrote: > Now that mem_cgroup_pre_destroy callback doesn't fail (other than a race > with a task attach resp. child group appears) finally we can safely move > on and forbit all the callbacks to fail. > The last missing piece is moving cgroup_call_pre_destroy after > cgroup_clear_css_refs so that css_tryget fails so no new charges for the > memcg can happen. > We cannot, however, move cgroup_call_pre_destroy right after because we > cannot call mem_cgroup_pre_destroy with the cgroup_lock held (see > 3fa59dfb cgroup: fix potential deadlock in pre_destroy) so we have to > move it after the lock is released. > > Changes since v1 > - Li Zefan pointed out that mem_cgroup_pre_destroy cannot be called with > cgroup_lock held > > Signed-off-by: Michal Hocko <mhocko@xxxxxxx> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>