On Mon, Nov 12, 2012 at 08:10:27PM -0500, Johannes Weiner wrote: > On Tue, Nov 13, 2012 at 01:31:55AM +0900, Joonsoo Kim wrote: > > It is somehow strange that alloc_bootmem return virtual address > > and free_bootmem require physical address. > > Anyway, free_bootmem()'s first parameter should be physical address. > > > > There are some call sites for free_bootmem() with virtual address. > > So fix them. > > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Joonsoo Kim <js1304@xxxxxxxxx> > > Found another one, attached below. The free_bootmem() in > arch/powerpc/platforms/82xx/pq2ads-pci-pic.c looks also fishy, since > it's applied to memory from kzalloc(). Ben? Eh, missed the smu.c one in Joonsoo's patch. powerpc one still strange. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>