On 11/09/2012 05:29 AM, Andrew Morton wrote: > On Thu, 8 Nov 2012 13:01:26 -0800 > Andi Kleen <andi@xxxxxxxxxxxxxx> wrote: > >> From: Andi Kleen <ak@xxxxxxxxxxxxxxx> >> >> Not hooked up to the harness so far, because it usually needs >> special boot options for 1GB pages. > > This isn't the case from my reading: we *can* hook it up now? > >> index b336b24..7300d07 100644 >> --- a/tools/testing/selftests/vm/Makefile >> +++ b/tools/testing/selftests/vm/Makefile >> @@ -1,9 +1,9 @@ >> # Makefile for vm selftests >> >> CC = $(CROSS_COMPILE)gcc >> -CFLAGS = -Wall -Wextra >> +CFLAGS = -Wall > > Why this? It doesn't change anything with my gcc so I think > I'll revert that. > >> >> ... >> > > Also... > > I just tried a `make run_vmtests' and it fell on its face. > There's a little comment in there saying "please run as root", but we > don't *want* that. The selftests should be runnable as non-root and > should, where unavoidable, emit a warning and proceed if elevated > permissions are required. Hi andrew: below code need root, I agree warning in case non-root is good, If you like I can fix it. echo $(( $lackpgs + $nr_hugepgs )) > /proc/sys/vm/nr_hugepages > > I tried running it as root and my workstation hung, requiring a reboot. > Won't be doing that again. > > Dave, could you please have a dig at this sometime? I can not reproduce the hang, will keep an eye on this. -- Thanks Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>