Re: [PATCH] Add a test program for variable page sizes in mmap/shmget v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 8 Nov 2012 14:01:50 -0800
Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:

> On Thu, Nov 08, 2012 at 01:29:46PM -0800, Andrew Morton wrote:
> > On Thu,  8 Nov 2012 13:01:26 -0800
> > Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > 
> > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > 
> > > Not hooked up to the harness so far, because it usually needs
> > > special boot options for 1GB pages.
> > 
> > This isn't the case from my reading: we *can* hook it up now?
> 
> Yes, but also need to set the sysctls.

That doesn't sound terribly involved?

> > > index b336b24..7300d07 100644
> > > --- a/tools/testing/selftests/vm/Makefile
> > > +++ b/tools/testing/selftests/vm/Makefile
> > > @@ -1,9 +1,9 @@
> > >  # Makefile for vm selftests
> > >  
> > >  CC = $(CROSS_COMPILE)gcc
> > > -CFLAGS = -Wall -Wextra
> > > +CFLAGS = -Wall
> > 
> > Why this?  It doesn't change anything with my gcc so I think
> > I'll revert that.
> 
> There were lots of warnings with signed/unsigned comparisons on my gcc
> (4.6) and since I personally consider those useless I just disabled
> the warning.

eh, OK, I'll update the changelog.

> > 
> > I just tried a `make run_vmtests' and it fell on its face. 
> > There's a little comment in there saying "please run as root", but we
> > don't *want* that.  The selftests should be runnable as non-root and
> > should, where unavoidable, emit a warning and proceed if elevated
> > permissions are required.
> 
> My test requires root. That is only the ipc test requires root.
> To be honest I have no idea why but I don't claim to understand
> why ipcperms() does all the weird stuff it does.
> 
> 
> > 
> > I tried running it as root and my workstation hung, requiring a reboot.
> > Won't be doing that again.
> 
> My test system didn't hang FWIW.

It wasn't thuge-gen which hung.  It happened really early in
run_vmtests, perhaps setting nr_hugepages.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]