On Mon, 5 Nov 2012 14:47:04 -0800 Michel Lespinasse <walken@xxxxxxxxxx> wrote: > Fix the x86-64 cache alignment code to take pgoff into account. > Use the x86 and MIPS cache alignment code as the basis for a generic > cache alignment function. > > The old x86 code will always align the mmap to aliasing boundaries, > even if the program mmaps the file with a non-zero pgoff. > > If program A mmaps the file with pgoff 0, and program B mmaps the > file with pgoff 1. The old code would align the mmaps, resulting in > misaligned pages: > > A: 0123 > B: 123 > > After this patch, they are aligned so the pages line up: > > A: 0123 > B: 123 We have a bit of a history of fiddling with coloring and finding that the changes made at best no improvement. Or at least, that's my perhaps faulty memory of it. This one needs pretty careful testing, please. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>