On Mon, 5 Nov 2012 01:46:36 -0500 Xi Wang <xi.wang@xxxxxxxxx> wrote: > First, `dev' is dereferenced in dev_to_node(dev), suggesting that it > must be non-null. Later `dev' is checked against NULL, suggesting > the opposite. This patch adds a NULL check before its use. > > ... > > @@ -159,7 +160,9 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, > return NULL; > } > > - retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev)); > + node = dev ? dev_to_node(dev) : -1; > + > + retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, node); > if (!retval) > return retval; Well, the dma_pool_create() kerneldoc does not describe dev==NULL to be acceptable usage and given the lack of oops reports, we can assume that no code is calling this function with dev==NULL. So I think we can just remove the code which handles dev==NULL? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>