Hello, Andrew. 2012/10/29 JoonSoo Kim <js1304@xxxxxxxxx>: > Hi, Minchan. > > 2012/10/29 Minchan Kim <minchan@xxxxxxxxxx>: >> Hi Joonsoo, >> >> On Mon, Oct 29, 2012 at 04:12:51AM +0900, Joonsoo Kim wrote: >>> This patchset clean-up and optimize highmem related code. >>> >>> [1] is just clean-up and doesn't introduce any functional change. >>> [2-3] are for clean-up and optimization. >>> These eliminate an useless lock opearation and list management. >>> [4-5] is for optimization related to flush_all_zero_pkmaps(). >>> >>> Joonsoo Kim (5): >>> mm, highmem: use PKMAP_NR() to calculate an index of pkmap >>> mm, highmem: remove useless pool_lock >>> mm, highmem: remove page_address_pool list >>> mm, highmem: makes flush_all_zero_pkmaps() return index of last >>> flushed entry >>> mm, highmem: get virtual address of the page using PKMAP_ADDR() >> >> This patchset looks awesome to me. >> If you have a plan to respin, please CCed Peter. > > Thanks for review. > I will wait more review and respin, the day after tomorrow. > Version 2 will include fix about your comment. Could you pick up second version of this patchset? [3] is changed to leave one blank line. [4] is changed in order to further optimize according to Minchan's comment. It return first index of flushed entry, instead of last index. Others doesn't changed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>