> From: Minchan Kim [mailto:minchan@xxxxxxxxxx] > Subject: [PATCH v3 0/3] zram/zsmalloc promotion > > The candidate is two under mm/ or under lib/ > Konrad and Nitin wanted to put zsmalloc into lib/ instead of mm/. > > Quote from Nitin > " > I think mm/ directory should only contain the code which is intended > for global use such as the slab allocator, page reclaim code etc. > zsmalloc is used by only one (or possibly two) drivers, so lib/ seems > to be the right place. > " > > Quote from Konrand > " > I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more > appropriate since it is dealing with storing a bunch of pages in a nice > layout for great density purposes. > " > > In fact, there is some history about that. > > Why I put zsmalloc into under mm firstly was that Andrew had a concern > about using strut page's some fields freely in zsmalloc so he wanted > to maintain it in mm/ if I remember correctly. > > So I and Nitin tried to ask the opinion to akpm several times > (at least 6 and even I sent such patch a few month ago) but didn't get > any reply from him so I guess he doesn't have any concern about that > any more. > > In point of view that it's an another slab-like allocator, > it might be proper under mm but it's not popular as current mm's > allocators(/SLUB/SLOB and page allocator). > > Frankly speaking, I don't care whether we put it to mm/ or lib/. > It seems contributors(ex, Nitin and Konrad) like lib/ and Andrew is still > silent. That's why I am biased into lib/ now. > > If someone yell we should keep it to mm/ by logical claim, I can change > my mind easily. Please raise your hand. > > If Andrew doesn't have a concern about that any more, I would like to > locate it into /lib. FWIW, I would vote for /lib as well. Dan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href