On Wed, Oct 24, 2012 at 6:57 PM, Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> wrote: > On 10/24/2012 03:48 PM, Borislav Petkov wrote: >> On Wed, Oct 24, 2012 at 02:18:38PM -0700, Dave Hansen wrote: >>> Sounds fairly valid to me. But, it's also one that would not be harmed >>> or disrupted in any way because of a single additional printk() during >>> each suspend-to-disk operation. >> >> back to the drop_caches patch. How about we hide the drop_caches >> interface behind some mm debugging option in "Kernel Hacking"? Assuming >> we don't need it otherwise on production kernels. Probably make it >> depend on CONFIG_DEBUG_VM like CONFIG_DEBUG_VM_RB or so. >> >> And then also add it to /proc/vmstat, in addition. > > That effectively means removing it from the kernel since distros ship > with those config options off. We don't want to do that since there > _are_ valid, occasional uses like benchmarking that we want to be > consistent. Agreed. we don't want to remove valid interface never. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>