On Mon, 22 Oct 2012, Glauber Costa wrote: > With this, plus the statement in setup_cpu_cache, it is possible that we > set the state to PARTIAL from two different locations. Although it > wouldn't be the first instance of it, I can't say I am a big fan. > > Is there any reason why you need to initialize the state to PARTIAL from > two different locations? No reason that I can think of. Was useful for me to think things through. Lets just drop the one that I added. Runs with without it. > I would just just get rid of the second and keep this one, which is > called early enough and unconditionally. > > > + } else > > + if (slab_state == PARTIAL) { > > + /* > > } else if ... Ok also fixed up. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>