On Mon, Oct 22, 2012 at 11:11 AM, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: >>> ?? >>> If resource was not allocated a driver, a driver doesn't need to >>> deallocate it when >>> error path. I haven't caught your point. >>> >> >> REMOVAL_NORMAL can be in 2 cases: >> 1. error path. If init call fails, we don't call it. We call this function >> only when something fails after init. >> 2. unbind the device from the driver. >> If we don't offline and remove memory when unbinding the device from the driver, >> the device may be out of control. When we eject this driver, we don't offline and > > Memory never be out of control by driver unloading. It is controled > from kernel core. It is an exception from regular linux driver model. Ah, got it. acpi_bus_hot_remove_device() evaluate PS3 before EJ0. Then your first patch may cause memory lost. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>