Re: [PATCH] MM: Support more pagesizes for MAP_HUGETLB/SHM_HUGETLB v6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Maybe I am missing something obvious, but does this not conflict with
> include/uapi/asm-generic/mman-common.h:
> 
> #ifdef CONFIG_MMAP_ALLOW_UNINITIALIZED
> # define MAP_UNINITIALIZED 0x4000000
> ...
> 
> 0x4000000 == (1 << 26
> 

You're right. Someone added that since I wrote the patch originally.
I owned them when originally submitted @) Thanks for catching.

Have to move my bits two up, which will still work, but limit the
maximum page size slightly more, but will likely still work for most
people.

I'll send a new patch.

BTW seriously MAP_UNINITIALIZED? Who came up with that? 
MAP_COMPLETELY_INSECURE or MAP_INSANE would have been more appropiate.
Maybe I should list as an advantage that my patch will prohibit
too many further such "innovations".

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]