On 10/19/2012 02:42 AM, Andrew Morton wrote: > On Wed, 17 Oct 2012 15:36:51 +0400 > Glauber Costa <glommer@xxxxxxxxxxxxx> wrote: > >> Some flags are used internally by the allocators for management >> purposes. One example of that is the CFLGS_OFF_SLAB flag that slab uses >> to mark that the metadata for that cache is stored outside of the slab. >> >> No cache should ever pass those as a creation flags. We can just ignore >> this bit if it happens to be passed (such as when duplicating a cache in >> the kmem memcg patches). > > I may be minunderstanding this, but... > > If some caller to kmem_cache_create() is passing in bogus flags then > that's a bug, and it is undesirable to hide such a bug in this fashion? > Not necessarily. This part is part of the kmemcg-slab series. In that use case, I copy the flags from the original kmem cache, and create a duplicate. That duplicate need to have the same flags, but only the creation flags. We had many attempts to mask it out in different places, and after some discussion, it seemed best to independently do it from common code in slab_common.c at creation time. It gets quite independent from the kmemcg-slab this way, and so I posted independently to reduce my churn -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>