On Fri, Oct 19, 2012 at 4:15 AM, David Rientjes <rientjes@xxxxxxxxxx> wrote: > On Thu, 18 Oct 2012, Bob Liu wrote: > >> Introduce hugepage_get_pmd() to simple code. >> > > I don't see this as simple just because you're removing more lines, I find > pagetable walks to be harder to read when split up like this and the "get" > part implies you're grabbing a reference on the pmd, which you're not. There are really too much place(at least four) do pagetable walks in thp. My original idea was putting them into one pagewalk fucntion together, that would be clearer and more readable. But there are several different pmd checks, no better way found to collect them currently. i'll keep on working on that. Thanks. -- Regards, --Bob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>