>>>>> Hmm, it doesn't move the code. It just reuse the code in acpi_memory_powerdown_device(). >>>> >>>> Even if reuse or not reuse, you changed the behavior. If any changes >>>> has no good rational, you cannot get an ack. >>> >>> I don't understand this? IIRC, the behavior isn't changed. >> >> Heh, please explain why do you think so. > > We just introduce a function, and move codes from acpi_memory_disable_device() to the new > function. We call the new function in acpi_memory_disable_device(), so the function > acpi_memory_disable_device()'s behavior isn't changed. > > Maybe I don't understand what do you want to say. Ok, now you agreed you moved the code, yes? So then, you should explain why your code moving makes zero impact other acpi_memory_disable_device() caller. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>