On Tue, Oct 16, 2012 at 10:00 PM, Fengguang Wu <fengguang.wu@xxxxxxxxx> wrote:
> On Wed, Oct 17, 2012 at 12:28:05AM +0530, raghu.prabhu13@xxxxxxxxx wrote:
>> From: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
>>
>> >From 51daa88ebd8e0d437289f589af29d4b39379ea76, page_sync_readahead coalesces
>> async readahead into its readahead window, so another checking for that again is
>> not required.
>>
>> Signed-off-by: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
>> ---
>> fs/btrfs/relocation.c | 10 ++++------
>> mm/filemap.c | 3 +--
>> 2 files changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
>> index 4da0865..6362003 100644
>
>> --- a/fs/btrfs/relocation.c
>> +++ b/fs/btrfs/relocation.c
>> @@ -2996,12 +2996,10 @@ static int relocate_file_extent_cluster(struct inode *inode,
>> ret = -ENOMEM;
>> goto out;
>> }
>> - }
>> -
>> - if (PageReadahead(page)) {
>> - page_cache_async_readahead(inode->i_mapping,
>> - ra, NULL, page, index,
>> - last_index + 1 - index);
>> + } else if (PageReadahead(page)) {
>> + page_cache_async_readahead(inode->i_mapping,
>> + ra, NULL, page, index,
>> + last_index + 1 - index);
>
> That extra indent is not necessary.
>
> Otherwise looks good to me. Thanks!
>
> Reviewed-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Hi Raghavendra,
Indentation breakage is now welcome. Please respin it. Otherwise
Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>