On Mon, Oct 15, 2012 at 01:54:13PM +0530, Srikar Dronamraju wrote: > * Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> [2012-10-13 23:36:18]: > > > > + > > > +bool numa_hinting_fault(struct page *page, int numpages) > > > +{ > > > + bool migrated = false; > > > + > > > + /* > > > + * "current->mm" could be different from the "mm" where the > > > + * NUMA hinting page fault happened, if get_user_pages() > > > + * triggered the fault on some other process "mm". That is ok, > > > + * all we care about is to count the "page_nid" access on the > > > + * current->task_autonuma, even if the page belongs to a > > > + * different "mm". > > > + */ > > > + WARN_ON_ONCE(!current->mm); > > > > Given the above comment, Do we really need this warn_on? > > I think I have seen this warning when using autonuma. > > > > ------------[ cut here ]------------ > WARNING: at ../mm/autonuma.c:359 numa_hinting_fault+0x60d/0x7c0() > Hardware name: BladeCenter HS22V -[7871AC1]- > Modules linked in: ebtable_nat ebtables autofs4 sunrpc cpufreq_ondemand acpi_cpufreq freq_table mperf bridge stp llc iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables ipv6 vhost_net macvtap macvlan tun iTCO_wdt iTCO_vendor_support cdc_ether usbnet mii kvm_intel kvm microcode serio_raw lpc_ich mfd_core i2c_i801 i2c_core shpchp ioatdma i7core_edac edac_core bnx2 ixgbe dca mdio sg ext4 mbcache jbd2 sd_mod crc_t10dif mptsas mptscsih mptbase scsi_transport_sas dm_mirror dm_region_hash dm_log dm_mod > Pid: 116, comm: ksmd Tainted: G D 3.6.0-autonuma27+ #3 The kernel is tainted "D" which implies that it has already oopsed before this warning was triggered. What was the other oops? -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>