On Thu, Oct 04, 2012 at 01:50:56AM +0200, Andrea Arcangeli wrote:
> This resets all per-thread and per-process statistics across exec
> syscalls or after kernel threads detach from the mm. The past
> statistical NUMA information is unlikely to be relevant for the future
> in these cases.
>
Unlikely is an understatement.
> Acked-by: Rik van Riel <riel@xxxxxxxxxx>
> Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
> ---
> fs/exec.c | 7 +++++++
> mm/mmu_context.c | 3 +++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 574cf4d..1d55077 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -55,6 +55,7 @@
> #include <linux/pipe_fs_i.h>
> #include <linux/oom.h>
> #include <linux/compat.h>
> +#include <linux/autonuma.h>
>
> #include <asm/uaccess.h>
> #include <asm/mmu_context.h>
> @@ -1172,6 +1173,12 @@ void setup_new_exec(struct linux_binprm * bprm)
>
> flush_signal_handlers(current, 0);
> flush_old_files(current->files);
> +
> + /*
> + * Reset autonuma counters, as past NUMA information
> + * is unlikely to be relevant for the future.
> + */
> + autonuma_setup_new_exec(current);
> }
> EXPORT_SYMBOL(setup_new_exec);
>
> diff --git a/mm/mmu_context.c b/mm/mmu_context.c
> index 3dcfaf4..e6fff1c 100644
> --- a/mm/mmu_context.c
> +++ b/mm/mmu_context.c
> @@ -7,6 +7,7 @@
> #include <linux/mmu_context.h>
> #include <linux/export.h>
> #include <linux/sched.h>
> +#include <linux/autonuma.h>
>
> #include <asm/mmu_context.h>
>
> @@ -52,6 +53,8 @@ void unuse_mm(struct mm_struct *mm)
> {
> struct task_struct *tsk = current;
>
> + autonuma_setup_new_exec(tsk);
> +
Why are the stats discarded in unuse_mm? That does not seem necessary at
all. Why would AIO being completed cause the stats to reset?
> task_lock(tsk);
> sync_mm_rss(mm);
> tsk->mm = NULL;
>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>