On Tue, Mar 18, 2025 at 08:59:59AM +0100, Vlastimil Babka wrote: > On 3/15/25 18:49, Shakeel Butt wrote: > > refill_stock can not be called with root memcg, so there is no need to > > check it. > > > > Signed-off-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> > > Acked-by: Vlastimil Babka <vbabka@xxxxxxx> > > It's not trivial to verify this so I'd add > VM_WARN_ON_ONCE(mem_cgroup_is_root(memcg)); as Roman suggested in patch 4 reply. > Ack, will do in the next version.