On Thu, Mar 20, 2025 at 08:00:36AM -0700, Andrei Vagin wrote: > On Thu, Mar 20, 2025 at 4:04 AM Lorenzo Stoakes > <lorenzo.stoakes@xxxxxxxxxx> wrote: > > > > Well I guess it couldn't wait ;) we're (very!) late in the cycle and > > immediately pre-LSF (will you be there btw?) so this is 6.16 for sure. > > > > Kinda wish you'd mentioned you wanted to do it as I'd rearranged my > > schedule to tackle this as a priority post-LSF, but you've done a good job > > so we're all good! Just a little heads up would have been nice ;) > > > > Some nits and you need to fix the test header thing but otherwise good. > > I wasn't rushing these changes. Just trying to help and save you some > time:). We'd like to backport this to older releases, but that's a separate > task. I'll submit backport requests to the stable branches and hope > (fingers crossed) the maintainers approve them. Sorry I didn't let you know > I could help with this. Please don't submit any backport requests yet, let me handle that for both. I mean I'm a maintainer of memory mapping bits, at least, so I approve from my side :) Andrew's input is necessary for rest, but let me handle that just so we don't step on each other's toes here too much! > > Thanks for the review. > > P.S. I don't think I made the CRIU urgency clear enough earlier. We're not > in panic mode, and we do have time to handle this. The lightweight guard > regions are in glibc, but aren't in any distro releases yet. We found the > problem when CRIU tests started failing on Fedora Rawhide. We probably have > a few months before the new glibc hits official distros and becomes a real > issue for CRIU users. Good! I am eager to avoid any issues here. You'll find us in mm to be responsive :) > > Thanks, > Andrei Cheers, Lorenzo
