On Wed, Mar 19, 2025 at 03:21:49PM -0700, JP Kobryn wrote: > @@ -779,6 +784,9 @@ struct cgroup_subsys { > * specifies the mask of subsystems that this one depends on. > */ > unsigned int depends_on; > + > + spinlock_t lock; > + raw_spinlock_t __percpu *percpu_lock; Please further qualify the names. > -/* Related to global: cgroup_rstat_lock */ > +/* Related to locks: > + * rstat_base_lock when handling cgroup::self > + * css->ss->lock otherwise > + */ Comment style, here and in other places. Thanks. -- tejun