On Thu, Mar 20, 2025 at 08:13:24AM +0100, Krzysztof Kozlowski wrote:
> On 20/03/2025 02:55, Changyuan Lyu wrote:
> >
> > +/**
> > + * early_init_dt_check_kho - Decode info required for kexec handover from DT
> > + */
> > +static void __init early_init_dt_check_kho(void)
> > +{
> > + unsigned long node = chosen_node_offset;
> > + u64 kho_start, scratch_start, scratch_size;
> > + const __be32 *p;
> > + int l;
> > +
> > + if (!IS_ENABLED(CONFIG_KEXEC_HANDOVER) || (long)node < 0)
> > + return;
> > +
> > + p = of_get_flat_dt_prop(node, "linux,kho-fdt", &l);
>
>
> You are adding undocumented ABI for OF properties. That's not what was
> explained last time.
>
> NAK.
Also there are checkpatch warnings :/
Best regards,
Krzysztof
