On Wed, Mar 19, 2025 at 04:22:46PM -0300, Jason Gunthorpe wrote: > On Wed, Mar 19, 2025 at 06:11:02PM +0000, Catalin Marinas wrote: > > On Wed, Mar 19, 2025 at 02:04:29PM -0300, Jason Gunthorpe wrote: > > > On Wed, Mar 19, 2025 at 12:01:29AM -0700, Oliver Upton wrote: > > > > You have a very good point that KVM is broken for cacheable PFNMAP'd > > > > crap since we demote to something non-cacheable, and maybe that > > > > deserves fixing first. Hopefully nobody notices that we've taken away > > > > the toys... > > > > > > Fixing it is either faulting all access attempts or mapping it > > > cachable to the S2 (as this series is trying to do).. > > > > As I replied earlier, it might be worth doing both - fault on !FWB > > hardware (or rather reject the memslot creation), cacheable S2 > > otherwise. > > I have no objection, Ankit are you able to make a failure patch? I'd wait until the KVM maintainers have their say. -- Catalin
