On Wed, 3 Oct 2012, Christoph Lameter wrote: > > > Acked-by: Glauber Costa <glommer@xxxxxxxxxxxxx> > > > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> > > > > Acked-by: David Rientjes <rientjes@xxxxxxxxxx> > > > > I think init_kmem_cache_cpus() would also benefit from just being inlined > > into alloc_kmem_cache_cpus(). > > The compiler will do that if it is advantageous. > Which it obviously does with -O2, but I think it would be advantageous to do this at the source code level as well since we have a function with a single caller, which happens to be marked inline itself, but we're not inline. It seems cleaner to me, but it's only a suggestion. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>