On Fri, 14 Mar 2025 10:59:31 +0100 Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote:
> On 2025-03-13 15:08:14 [-0700], Andrew Morton wrote:
> > That would be nice, if you think it makes sense. There is some
> > duplication here.
>
> As you wish. That would be the following patch below.
Looks OK.
> This is now
> somehow unique compared to the other interfaces (like vmalloc() vs
> vmalloc_node()).
I'm not sure what this means?
I kinda struggle with the name "vmalloc_huge_node". But
"vmalloc_node_maybe_huge" is too long!
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -207,7 +207,23 @@ void *vmalloc_noprof(unsigned long size)
> }
> EXPORT_SYMBOL(vmalloc_noprof);
>
> -void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) __weak __alias(__vmalloc_noprof);
> +/*
> + * vmalloc_huge_node - allocate virtually contiguous memory, on a node
> + *
> + * @size: allocation size
> + * @gfp_mask: flags for the page level allocator
> + * @node: node to use for allocation or NUMA_NO_NODE
> + *
> + * Allocate enough pages to cover @size from the page level
> + * allocator and map them into contiguous kernel virtual space.
> + *
> + * Due to NOMMU implications the node argument and HUGE page attribute is
> + * ignored.
> + */
> +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node)
> +{
> + return __vmalloc_noprof(size, gfp_mask);
> +}
Please check, I think this wants to be EXPORTed to modules.
> -void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask)
> +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node)
> {
> return __vmalloc_node_range_noprof(size, 1, VMALLOC_START, VMALLOC_END,
> - gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP,
> - NUMA_NO_NODE, __builtin_return_address(0));
> + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP,
> + node, __builtin_return_address(0));
> }
> -EXPORT_SYMBOL_GPL(vmalloc_huge_noprof);
> +EXPORT_SYMBOL_GPL(vmalloc_huge_node_noprof);
Like the NOMMU=n version.
