When invoke vmap_pfns, it call vmap_pfn_apply to set pfn into pte. It check pfn is valid, if true then warn and return. This is a mischeck, actually we need set a valid pfn into pte, not an invalid pfn. This patch fix it. Signed-off-by: Huan Yang <link@xxxxxxxx> Reported-by: Bingbu Cao <bingbu.cao@xxxxxxxxxxxxxxx> Closes: https://lore.kernel.org/dri-devel/eb7e0137-3508-4287-98c4-816c5fd98e10@xxxxxxxx/T/#mbda4f64a3532b32e061f4e8763bc8e307bea3ca8 Fixes: b3f78e749865 ("mm: vmalloc must set pte via arch code") --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 044af7088359..ebadb8ceeba7 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3488,7 +3488,7 @@ static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private) unsigned long pfn = data->pfns[data->idx]; pte_t ptent; - if (WARN_ON_ONCE(pfn_valid(pfn))) + if (WARN_ON_ONCE(!pfn_valid(pfn))) return -EINVAL; ptent = pte_mkspecial(pfn_pte(pfn, data->prot)); -- 2.39.0
