Re: [PATCH] block: add lock for safe nrpages access in invalidate_bdev()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yuan Tan <tanyuan@xxxxxxxxxxx>
Subject: Re: [PATCH] block: add lock for safe nrpages access in invalidate_bdev()
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Mon, 10 Mar 2025 17:11:22 +0000
Cc: axboe@xxxxxxxxx, syzbot+f2aaf773187f5cae54f3@xxxxxxxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, syzkaller-bugs@xxxxxxxxxxxxxxxx, falcon@xxxxxxxxxxx
In-reply-to: <20250310165400.3166618-1-tanyuan@tinylab.org>
References: <67ceb38a.050a0220.e1a89.04b1.GAE@google.com> <20250310165400.3166618-1-tanyuan@tinylab.org>

On Mon, Mar 10, 2025 at 09:54:00AM -0700, Yuan Tan wrote:
> Syzbot reported a data-race in __filemap_add_folio / invalidate_bdev[1]
> due to concurrent access to mapping->nrpages.
> Adds a lock around the access to nrpages.

Did you even read my analysis?  This is a grossly inappropriate fix.
NAK.

References:
- [syzbot] [mm?] [fs?] KCSAN: data-race in __filemap_add_folio / invalidate_bdev (8)
  - From: syzbot
- [PATCH] block: add lock for safe nrpages access in invalidate_bdev()
  - From: Yuan Tan

Prev by Date: Re: [PATCH v4 06/14] kexec: Add KHO parsing support
Next by Date: Re: [PATCH v2 3/3] ras: mem: Add memory ACPI RAS2 driver
Previous by thread: [PATCH] block: add lock for safe nrpages access in invalidate_bdev()
Next by thread: [RFC 0/2] mm/ptdump: Drop assumption that pxd_val() is u64
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux