On Mon, 10 Mar 2025 14:51:37 +0100 Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> This warning is for potentially user-defined format strings:
>
> mm/damon/sysfs-schemes.c:1664:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
> 1664 | name);
>
> Change this to use "%s" as the format and the name as the argument.
Thank you for this patch!
>
> Fixes: 92bc039dd72e ("mm/damon/sysfs-schemes: let damon_sysfs_scheme_set_filters() be used for different named directories")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
Thanks,
SJ
> ---
> mm/damon/sysfs-schemes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
> index 50e6907515e6..23ac98dd6451 100644
> --- a/mm/damon/sysfs-schemes.c
> +++ b/mm/damon/sysfs-schemes.c
> @@ -1661,7 +1661,7 @@ static int damon_sysfs_scheme_set_filters(struct damon_sysfs_scheme *scheme,
> return -ENOMEM;
> err = kobject_init_and_add(&filters->kobj,
> &damon_sysfs_scheme_filters_ktype, &scheme->kobj,
> - name);
> + "%s", name);
> if (err)
> kobject_put(&filters->kobj);
> else
> --
> 2.39.5
