On Mon, Mar 10, 2025 at 02:04:17PM +0000, Ryan Roberts wrote: > It is best practice for all pte accesses to go via the arch helpers, to > ensure non-torn values and to allow the arch to intervene where needed > (contpte for arm64 for example). While in this case it was probably safe > to directly dereference, let's tidy it up for consistency. > > Signed-off-by: Ryan Roberts <ryan.roberts@xxxxxxx> LGTM, so: Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 22e270f727ed..33a22c2d6b20 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -202,7 +202,7 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, > return false; > VM_BUG_ON_PAGE(!PageAnon(page), page); > VM_BUG_ON_PAGE(!PageLocked(page), page); > - VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page); > + VM_BUG_ON_PAGE(pte_present(ptep_get(pvmw->pte)), page); > > if (folio_test_mlocked(folio) || (pvmw->vma->vm_flags & VM_LOCKED) || > mm_forbids_zeropage(pvmw->vma->vm_mm)) > -- > 2.43.0 >
