On Thu, Mar 6, 2025 at 3:42 PM Yosry Ahmed <yosry.ahmed@xxxxxxxxx> wrote: > > > + * > > + * -EINVAL: some of the subpages in the folio are zeromaped, but not all of > > + * them. This is an error because we don't currently support a large folio > > + * that is partially in the zeromap. The folio is unlocked, but NOT marked > > + * up-to-date, so that an IO error is emitted (e.g. do_swap_page() will > > + * sigbus). > > This is a bit repetitive. Maybe: > > * -EINVAL: The folio is partially in the zeromap, which is not > * currently supported. The folio is unlocked, but NOT marked > * up-to-date, so that an IO error is emitted (e.g. do_swap_page() will > * sigbus). > > > > I would drop this whole comment now because it's mostly repeating what's > now documneted above. > > With the comments fixed up: > > Reviewed-by: Yosry Ahmed <yosry.ahmed@xxxxxxxxx> > Ah I like both suggestions :) Gimme one sec to send out a fixlet. Thanks, Yosry!
