On (25/03/07 10:38), Herbert Xu wrote: > On Thu, Mar 06, 2025 at 04:55:07PM +0000, Yosry Ahmed wrote: > > > > The zswap and zsmalloc look good and the code is simpler. I am fine with > > this approach if Sergey is fine with it, although I wonder if we should > > update Sergey's patches in mm-unstable do this directly. Currently we > > are switching from mapping APIs to read/write APIs, and then quickly to > > the pinning APIs. The history will be confusing. > > > > Sergey, do you prefer if we keep things as-is, or if you update your > > series to incorporate Herbert's changes for zsmalloc/zram, then I can > > update my series to incorporate the changes in zswap? > > > > We can also combine the series into a single updated one with > > zsmalloc/zram/zswap changes. > > > > Let me know what you prefer. > > This patch is only illustrating what zswap would look like once we > move to an SG-based interface. So I'm not actually submitting it > for inclusion at this time. Ah, OK, that's good to know, I was also a bit puzzled. Perhaps next time we can label such patches as "POC" or something. > Sergey has volunteed to add parameter support to acomp. Let's > wait for that before making these changes to zsmalloc/zswap. Yup, I'll keep you posted (once I have something.)