Re: slab vs. slub kmem cache name inconsistency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This should be fixed the merge window for 3.7. All allocators will do a
kstrdup then.

On Tue, 2 Oct 2012, Johannes Berg wrote:

> Hi,
>
> I just noticed that slub's kmem_cache_create() will kstrdup() the name,
> while slab doesn't. That's a little confusing, since when you look at
> slub you can easily get away with passing a string you built on the
> stack, while that will then lead to very strange results (and possibly
> crashes?) with slab. The slab kernel-doc string always says this:
>
>  * @name must be valid until the cache is destroyed. This implies that
>  * the module calling this has to destroy the cache before getting unloaded.
>
> Is there any reason for this difference, or should slab also kstrdup(),
> or should slub not do it? Or maybe slub should have a "oops, name is on
> stack" warning/check?
>
> johannes
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]