Re: [PATCH v3 01/10] selftests/mm: Report errno when things fail in gup_longterm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



/*
  		 * TODO: if the kernel ever supports long-term R/W pinning on
@@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared)
  		/* Skip on errors, as we might just lack kernel support. */
  		ret = io_uring_queue_init(1, &ring, 0);
  		if (ret < 0) {
-			ksft_test_result_skip("io_uring_queue_init() failed\n");
+			ksft_test_result_skip("io_uring_queue_init() failed (%s)\n",
+					      strerror(errno));

This function is documented to return -errno. I'm not sure if errno is guaranteed to be left unmodified (not clearly documented in the man page). So you might just want to use strerror(-ret) here.

Same applies to the other io_uring functions.

--
Cheers,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux