On 10/01/2012 11:28 AM, Pekka Enberg wrote: > Hello, > > [ Found this in my @cs.helsinki.fi inbox, grmbl. ] > > On Fri, Sep 28, 2012 at 11:39 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote: >> The first prototype, SLAM XP1, will be posted in October. I'd simply like >> to avoid reverting this patch down the road and having all of us >> reconsider the topic again when clear alternatives exist that, in my >> opinion, make the code cleaner. > > David, I'm sure you know we don't work speculatively against > out-of-tree code that may or may not be include in the future... > > That said, I don't like Glauber's patch because it leaves CREATE_MASK > in mm/slab.c. And I'm not totally convinced a generic SLAB_INTERNAL is > going to cut it either. Hmm. > > Pekka > How about we require allocators to define their own CREATE_MASK, and then in slab_common.c we mask out any flags outside that mask? This way we can achieve masking in common code while still leaving the decision to the allocators. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>